Pull request followup¶
Once a patch has been submitted gerrit can be used to track progress.
Find your patch¶
Item of Note:
A Gerrit Change-Id is required to interact with a patch. This hashed value will be distinct from the underlying git checksum used when changes are stored in a repository.
Capture commit message output¶
Gerrit commit hash and a URL are readily available in output.
1% git commit -F ../jira/5100
2% git rebase
3% git review --reviewers tux@onf.org
4
5remote:
6remote: Processing changes: (\)
7remote: Processing changes: (|)
8remote: Processing changes: (/)
9remote: Processing changes: (-)
10remote: Processing changes: (\)
11remote: Processing changes: (|)
12remote: Processing changes: (/)
13remote: Processing changes: (-)
14remote: Processing changes: new: 1 (\)
15remote: Processing changes: refs: 1, new: 1 (\)
16remote: Processing changes: refs: 1, new: 1 (\)
17remote: Processing changes: refs: 1, new: 1, done
18remote:
19remote: SUCCESS
20remote:
21remote: https://gerrit.opencord.org/c/ci-management/+/34600 Disable jobs dependent on offline menlo-3 node [NEW]
22fremote:
23To ssh://gerrit.opencord.org:29418/ci-management.git
24 * [new reference] HEAD -> refs/for/master%topic=dev-joey
Id |
Line |
Description |
---|---|---|
2 |
Git commit hash |
|
10 |
Gerrit URL for direct patch access |
|
14 |
Git log¶
Gerrit Change-IDs are appended as the last line in a commit mesage. git log can be used to search for them.
1% git log --author="joey" | less
2
3commit 23ce887c4cb3f98506536e00c58ffc8c2af16afe
4Author: Joey Armstrong <joey@opennetworking.org>
5Date: Thu Aug 24 09:46:22 2023 -0400
6
7 [VOL-5009] - Update release notes
8
9 release_notes/voltha_2.12.rst
10 -----------------------------
11 o Import Mahir(s) word doc containing tickets and descriptions.
12 o Reformat using a grid layout so tickets and description are aligned.
13
14 Change-Id: Ic8ca17f5923496731f88ce8918c9852d904ea066
Id |
Line |
Description |
---|---|---|
23ce887c4cb3f98506536e00c58ffc8c2af16afe |
3 |
Git commit hash |
Ic8ca17f5923496731f88ce8918c9852d904ea066 |
14 |
Gerrit Change-Id |
Patch lookup by Change-Id string¶
When you have a Change-Id value (~43 chars)
Change-Id: Ic8ca17f5923496731f88ce8918c9852d904ea066
Visit the Gerrit dashboard
Paste Change-Id into the search box at the top right
Gerrit UI will navigate to the patch.
Brute force patch lookup¶
Visit Gerrit dashboard open+is:wip
View all open/unmerged patches
Scroll down through the list until something of interest is found.
Under the # column (2nd column on left hand side) right click and open to view the patch.
For example: repo:voltha-system-tests
Patch history and jenkins jobs¶
While viewing a patch (repo:voltha-system-tests) scroll down to the ‘Change Log’ section at the bottom. | Line items represent historical comments, code review messages and processed job status.
Entries prefixed with Jenkins Technical User
contain jenkins job
information. Jenkins pipeline jobs are constructed by performing
several atomic tasks each of which will generate a log with status.
To view job logs click on an entry to expand (Verified +1, 4th entry from the bottom) to view a set of clickable jenkins URLs.
Patch 33380 - verify_voltha-system-tests_unit-test : SUCCESS - verify_voltha-system-tests_licensed : SUCCESS - verify_voltha-system-tests_sanity-test : FAILED